fix(mcp): refresh complete catalogs and discover active tools - #198
Merged
Merged
Conversation
The non-strict Anthropic tool path keeps only `properties` and `required`, so a schema whose properties point at root `$defs` or `definitions` (as pydantic-based MCP servers emit for enums and nested models) was sent with dangling `$ref`s. MCP input schemas now reach the provider unchanged, so carry those local definitions along with the kept properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP startup registered only the first catalog page, and
find_toolssearched a captured built-in list. Collect complete catalogs, refresh filtered additions/updates/removals in one extension-owned batch, and search the active session catalog with callable parameter schemas.Preserve input schemas and bind output validation/task policy to each captured tool definition, avoiding SDK 1.27.1's mutable per-page metadata cache. Failed refreshes retain the last good catalog; shutdown and one-shot handshake cancellation close outstanding work. The SDK version is unchanged. Related to the closed #154 pagination proposal.
Validation:
npm run checkpnpm run build:offline./test.shwith isolated credentials